Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test to Explicitly Check Private Modules Exposed via API #25930

Closed
WillAyd opened this issue Mar 30, 2019 · 3 comments · Fixed by #25935
Closed

Add Test to Explicitly Check Private Modules Exposed via API #25930

WillAyd opened this issue Mar 30, 2019 · 3 comments · Fixed by #25935
Labels
good first issue Testing pandas testing functions or related to the test suite
Milestone

Comments

@WillAyd
Copy link
Member

WillAyd commented Mar 30, 2019

This is a follow up to this conversation:

#25884 (comment)

Want to update test_api to explicitly check private modules that may also be in the namespace

@WillAyd WillAyd added Testing pandas testing functions or related to the test suite good first issue labels Mar 30, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone Mar 30, 2019
@ryankarlos
Copy link
Contributor

@WillAyd Can I have a go at this ? If I understand correctly, the current test checks exclude private modules in the namespace - does the additional test need to go in pandas/tests/api/test_api.py or a separate file with a new Base class which only checks for private modules in the namespace ? Alternatively i'm guessing a new method check_private could be included with the existing Base class and another test added in the same file ?

@WillAyd
Copy link
Member Author

WillAyd commented Mar 30, 2019

@ryankarlos for sure! I think you can just remove the exclusion of private modules and list them out explicitly as part of the existing test

@ryankarlos
Copy link
Contributor

@WillAyd Thanks, will work on it !

@jreback jreback modified the milestones: Contributions Welcome, 0.25.0 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants