Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify test_value_counts_unique_nunique_null in pandas/tests/base/test_ops.py #32205

Closed
SaturnFromTitan opened this issue Feb 23, 2020 · 1 comment · Fixed by #32281
Closed

Simplify test_value_counts_unique_nunique_null in pandas/tests/base/test_ops.py #32205

SaturnFromTitan opened this issue Feb 23, 2020 · 1 comment · Fixed by #32281
Assignees
@SaturnFromTitan

Comments

@SaturnFromTitan
Copy link
Contributor

As stated by @jreback in his comment on #32046, there are some weird constructs, duplications and unreachable code in this test.

For more info see the mentioned PR and the unresolved comments in the bottom.

The other tests in this file have a similar problem, but should probably be a separate PR.
This was referenced Feb 23, 2020
Merged
Closed
@SaturnFromTitan
Copy link
Contributor Author

take

SaturnFromTitan added a commit to SaturnFromTitan/pandas that referenced this issue Feb 26, 2020
@SaturnFromTitan
[pandas-dev#32205] Simplify test_value_counts_unique_nunique_null in …
348bc72 
…pandas/tests/base/test_ops.py
@SaturnFromTitan SaturnFromTitan mentioned this issue Feb 26, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaturnFromTitan SaturnFromTitan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TST: Split and simplify test_value_counts_unique_nunique SaturnFromTitan/pandas
1 participant
@SaturnFromTitan