Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: value_counts tests failing sometimes #32220

Closed
dsaxton opened this issue Feb 24, 2020 · 4 comments · Fixed by #32281
Closed

CI: value_counts tests failing sometimes #32220

dsaxton opened this issue Feb 24, 2020 · 4 comments · Fixed by #32281
Assignees
@SaturnFromTitan
Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail

Comments

@dsaxton
Copy link
Member

dsaxton commented Feb 24, 2020

It seems like we're getting some failures from test_value_counts_unique_nunique in pandas/tests/base/test_ops.py (weird thing is that it only fails some of the time; maybe because of randomized test data?). Looks like these tests were updated in #32046; @SaturnFromTitan any ideas what might be happening there?

Sample failed pipeline: https://github.com/pandas-dev/pandas/runs/464853016
@SaturnFromTitan
Copy link
Contributor

SaturnFromTitan commented Feb 24, 2020 •
edited
Loading

Hm, that's weird. Looking at the error log above the test failed for the fixture value float16-series defined here.

If I recall correctly that fixture value wasn't used/tested in this test before. So possibly we can just remove it from the fixture again. I have no idea about why it's flaky/broken though...

@WillAyd
Copy link
Member

WillAyd commented Feb 24, 2020

We generally don’t support float16 so if it is causing test failures can probably remove

@SaturnFromTitan SaturnFromTitan mentioned this issue Feb 24, 2020
Merged
4 tasks
@AlexKirko AlexKirko mentioned this issue Feb 25, 2020
Merged
5 tasks
@jbrockmendel jbrockmendel added CI Continuous Integration Unreliable Test Unit tests that occasionally fail labels Feb 25, 2020
@SaturnFromTitan
Copy link
Contributor

xref: #32205

@SaturnFromTitan
Copy link
Contributor

take

@SaturnFromTitan SaturnFromTitan mentioned this issue Feb 26, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaturnFromTitan SaturnFromTitan

Labels
CI Continuous Integration Unreliable Test Unit tests that occasionally fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TST: Split and simplify test_value_counts_unique_nunique SaturnFromTitan/pandas
4 participants
@WillAyd @dsaxton @jbrockmendel @SaturnFromTitan