-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.21.0 wheels broken for older (<1.13) numpy version #18530
Comments
My assumption is this: for all python 3 versions we specify a build numpy version of at least 1.19.3 ( |
note this just broke in the last day or 2 |
I pushed some updates, lets see. |
Why would you say that? |
no our builds just broke |
It seems like uploading wheels to PyPI with the same name is a no-go. We would need to to bump the version somehow, perhaps with Users who want the "fixed" wheels with NumPy < 1.13 can install directly from the rackspace CDN, when the builds for MacPython/pandas-wheels@ec160e0 finish:
|
This one doesn't seem to work (I also don't see any 0.21.0 packages on there, only dev builds and rc). I did download the wheel from there manually, and verified the wheel is not working properly though (you need to add
Sorry, I don't understand. We only have one version of the wheels uploaded for 0.21.0, and they were broken from the beginning, no? |
There is a HTTPS link for the https://3f23b170c54c2533c070-1c8a9b3114517dc5fe17b7c3f8c63a43.ssl.cf2.rackcdn.com/ |
OK, so the full pip install command needed to install this version is:
(note the --no-index in the end, as otherwise it will still download the pypi one) |
the daily wheel generation has been working up until 3 or 4 days ago, its fixed now with the 2.7 numpy version pin. The only wheel that is an issue is the 2.7 one. as @TomAugspurger and I discussed in person, its not feasible to update this inplace on PyPi. the 0.21.1 release will fix this. Note we should have a small note in 0.21.1 whatsnew to indicate the problem is resolved. |
OK, but this issue was about the released version, not the daily one. I know we cannot update the wheel. Depending on how much time it will take, it's ok for me to wait until 0.21.1 (but that time might depend on the sum discussion) |
to be honest we should just release 0.21.1 soon as-is, pending the matplotlib fix issue only (the import warning); |
0.21.1 wheels are up, and should now be working. |
@jorisvandenbossche if I understand correctly, version However, I still get the same error, using Docker:
If I do |
@amir20 You are downloading the source files as tar.gz, not wheels. This issue was about a problem with how the wheels were built, but if you are building from source yourself, you still need to ensure that numpy is installed first. |
And you're getting source files since you're on alpine linux. The wheels on
PyPI are manylinux wheels, which
are not compatible with alpine: pypa/manylinux#37
…On Sun, Dec 17, 2017 at 1:38 AM, Joris Van den Bossche < ***@***.***> wrote:
@amir20 <https://github.com/amir20> You are downloading the source files
as tar.gz, not wheels. This issue was about a problem with how the wheels
were built, but if you are building from source yourself, you still need to
ensure that numpy is installed first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18530 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIpiGSb89QUIt58CZa53AVQMfVdlTks5tBMT-gaJpZM4QsSpH>
.
|
Oh that makes a lot more sense. 👍🏻 |
xref #16715 (comment)
I can reproduce what was reported in the other issue: in a clean env, first installing
python -m pip install numpy==1.11.2
and thenpython -m pip install pandas
(0.21.0) results in a broken install, while in principle our wheels should be build against the oldest supported numpy version and this should thus work.From a quick glance it however seems that the python 2.7 wheels are still build with numpy 1.7: https://github.com/MacPython/pandas-wheels/blob/master/.travis.yml
cc @TomAugspurger @jreback
The text was updated successfully, but these errors were encountered: