-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RLS 0.21.1 #18244
Comments
I would already include those things that are labeled for 0.21.1. We already had some regression fixed, so IMO it would be a bit stupid not to include this. |
yes this should include amy backports |
let’s wait till the meeting to discuss no really pressing PRs |
It there any chance someone could take a look at #18051 for 0.21.1? The issue is that ATM, if you are not absolutely sure that all values in a categorical series are not |
Let's not forget:
|
Yes, given the continuing stream of bug reports about that one, it would be nice to get a fix out as soon as possible. Although the sum needs some more time to discuss ... |
So we should plan for the 0.21.1 release. @TomAugspurger has some time the coming days (and I am also available to help). Regardless of the following questions, we can already start backporting and fixing the remaining issues https://github.com/pandas-dev/pandas/milestone/52. But the questions we need to answer:
and depending on that we need to discuss whether we call that 0.21.1 or 0.22.0, but let's first decide on the above question (again, which is tied to the result of the discussion, so the question is maybe more: do we wait on that, or we think we are ready to decide on it now). |
yeah the remaining issues I have only tagged if they are basically ready to merge. So I would say we could release at any time for 0.21.1 (obivously need to actually backport things :>) and prob some small doc cleanups in whatsnew. This should be 0.21.1. If/when we change the whole |
IMO we shouldn't let that sit in master for a bit, but release as quick as possible (and quick as possible might still mean a rc etc). |
why? we have a bug fix release already teed up. conflating a major change is just not a great idea. We have contentious small sample feedback, why would you exacerbate things? |
Because, supposing we go for option 1, we are changing the behaviour again. The longer we wait with doing this, the more people start relying on the intermediate behaviour that will go away, the more packages will need to implement workarounds, etc. |
and there is no consensus on option 1. |
Then please take the time to answer on the mailing list |
Since #18678 seems to be stuck at the moment, I propose that we clear the 0.21.1 issue list and do a release today. #18629 should be mergable, #18715 may have to wait for a fastparquet release. w.r.t doing a release with #18678 still unresolved, I care less about the number of release between now and the fix for it, and more about the number of calendar days. I want as few people as possible using this in-between behavior, and I think the number of days between 0.21.0 and a release with that fixed matters more than the number of releases. Given the matplotlib registry stuff, and the py27 wheels, I'd like to do a release soon, preferably today. |
lgtm |
Everything should be in place. I'll tag it tomorrow morning unless something comes up. |
It seems like Christoph is building wheels against CPython 3.7 too: https://www.lfd.uci.edu/~gohlke/pythonlibs/#pandas Unless anyone objects, I'll upload those to PyPI as well.
I'll send the announce out when the wheels are done. |
we have no testing at all against 3.7 |
Yep. I figure the two options are
1. We don't upload the wheels, and 3.7 users build from source. Stuff
either works or it doesn't.
2. We do upload the wheels, and users get the binary. Stuff either works or
it doesn't.
We know 0.21.1 builds on 3.7 on Windows, since Christoph was able to build
it. By uploading those
wheels, we get a bit more exposure to see if there are any issues with his
build system on 3.7, which
would be good to sort out early.
I don't know if uploading wheels for 3.7 is saying that "3.7 is officially
supported for pandas 0.21.1". I'd
say no.
…On Tue, Dec 12, 2017 at 1:35 PM, Jeff Reback ***@***.***> wrote:
we have no testing at all against 3.7
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18244 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIiq5qg-Q8k-SYwwoSZEJuPGsBlyLks5s_tVxgaJpZM4Qa8_Z>
.
|
Better not. These wheels are built with Python 3.7a3 and Visual Studio 2017. They might not work with later 3.7 releases. I'm just starting to test the scipy stack with Python 3.7 and VS 2017. |
Thanks for clarifying @cgohlke. |
@jreback : I think Travis has an image for Python 3.7, so maybe in the future, we could consider? |
we don’t use the travis images at all only conda |
Wheels are done, announcement is sent. Thanks everyone. |
@TomAugspurger Thanks a lot for the release! |
thanks @TomAugspurger it seems so easy now with your checklist!! hahaha |
Only a few dozen steps :)
…On Wed, Dec 13, 2017 at 8:09 AM, Jeff Reback ***@***.***> wrote:
thanks @TomAugspurger <https://github.com/tomaugspurger> it seems so easy
now with your checklist!! hahaha
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18244 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIqsqFrQD74BWy09HNvQH_Fmuh2W8ks5s_9qhgaJpZM4Qa8_Z>
.
|
thanks @TomAugspurger! |
Thanks!
…On Wed, Dec 13, 2017 at 8:07 AM Wes McKinney ***@***.***> wrote:
thanks @TomAugspurger <https://github.com/tomaugspurger>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18244 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABKS1ron-7Vn4xRVMANfxoPZXqbhPfpJks5s__ZdgaJpZM4Qa8_Z>
.
|
closes #18530
Release Checklist
This template can be copied into the RLS issue for a release and checked off as you go.
Pre-Release
build_dist.sh
, uninstall cython and make a test install of the tarball to ensurecython is not required for installation from tarball/pypi (now also part of travis scripts, but check).
pandas.pydata.org
(@TomAugspurger or Andy Terrel should be able to get you an account).The Release
Final Pre-Release
To be done just before tagging the commit. This is optional for release-candidates.
scripts/announce.py
and add torelease.rst
release.rst
andwhatsnew/<version>.rst
Tag the Release
git commit --allow-empty -m 'RLS: v0.20.0'
-m 'RLS: v0.20.0.rc2'
git tag -a v0.20.0
-m "Version 0.20.0"Test the Release
Some local sanity tests before pushing, making the release official
Push the Release
This is where things become final. No going back once the tagged commit is pushed
git push upstream master --follow-tags
git push upstream 0.20.x --follow-tags
Build Source Distribution
python setup.py sdist --formats=gztar
(TODO: update build_dist.sh to handle maintenance branches)Release on Github
pandas-<version>.tar.gz
from the previous step as a "binary"openssl dgst -sha256 dist/pandas-<version>.tar.gz
We use the SHA from our .tar.gz since the one auto-generated by Github isn't stable if the release page
is later modified.
Build Binary Distributions
Windows wheels are built automatically by Christoph Gohlke.
BUILD_COMMIT
hereDownload Binary Distributions
Conda-Forge is handled automatically. We handle wheels.
python scripts/fetch_wheels.py
, from hereUpload to PyPI
Upload the source and wheels simultaneously. Uploading just the source may break some users'
workflows, if they trigger an update but don't have a C-complier
dist
:twine upload dist/*
Build and Upload the Docs
Update the Website
https://github.com/pandas-dev/pandas-website.git
latest.rst
toprevious.rst
latest.rst
releases.json
andpre_release.json
(if RC, add to pre_release.json, else make it blank)_themes/pydata/layout.html
to have the most recent minor release of each major versionpython make.py html
python upload.py
# TODO: verify this worksAnnounce
** Final Version**
** Release Candidates **
Start the next release cycle
Only after a major release
When finishing a major release we have a few extra steps to ensure that
the development version is always ahead of the backports version.
git checkout -b 0.20.x master
git push -u upstream 0.20.x
git checkout master
git commit --allow-empty -m 'DEV: Start 0.21 cycle'
git tag -a v0.21.0.dev0 -m 'Version 0.21.0 start'
git push upstream master --follow-tags
Finish
Miscellany I haven't gotten to yet.
Update documentation
git log v0.18.1.. --format='%an#%s' | grep -v Merge > commits
release.rst
):cat commits | gawk -F '#' '{ print "- " $1 }' | sort | uniq
release.rst
with highlights of whatsnew).The text was updated successfully, but these errors were encountered: