ENH: add from_dataframe and DataFrame #331
Conversation
bashtage
commented
Sep 26, 2022
bashtage
commented
- xref Version 1.5 changes #227
There was a problem hiding this comment.
Unclear to me whether we should add tests for this? Other comments are related to checking the API definition at https://data-apis.org/dataframe-protocol/latest/API.html, which may reveal that we have issues in the pandas source in how this is typed.
| @abstractmethod | ||
| def __dlpack__(self): ... | ||
| @abstractmethod | ||
| def __dlpack_device__(self) -> tuple[DlpackDeviceType, int | None]: ... |
There was a problem hiding this comment.
Looking at https://data-apis.org/dataframe-protocol/latest/API.html, I don't think the second element of the tuple can be None
There was a problem hiding this comment.
Here
it is None. This is a concrete implementation.
| class Column(ABC, metaclass=abc.ABCMeta): | ||
| @property | ||
| @abstractmethod | ||
| def size(self) -> int: ... |
There was a problem hiding this comment.
Looking at https://data-apis.org/dataframe-protocol/latest/API.html, returns Optional[int]
There was a problem hiding this comment.
I think the spec type might also be wrong here. The text indicates that the size is required, either the full DF size or the chunk size if a single chunk.
