Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.5 changes #227

Closed
Dr-Irv opened this issue Aug 25, 2022 · 8 comments
Closed

Version 1.5 changes #227

Dr-Irv opened this issue Aug 25, 2022 · 8 comments

Comments

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 25, 2022

Need to update stubs for version 1.5 based on docs in RC:
https://pandas.pydata.org/pandas-docs/version/1.5.0rc0/whatsnew/v1.5.0.html

@phofl
Copy link
Member

phofl commented Sep 16, 2022

How do you want to handle deprecations of arguments? Remove them from the stubs immediately?

@bashtage
Copy link
Contributor

I think once we shift to 1.5 as the target we should fully target 1.5 including all deprecations.

@phofl
Copy link
Member

phofl commented Sep 16, 2022

So if argument x is deprecated we would just remove it from the stubs, correct?

@bashtage
Copy link
Contributor

That is what we have been doing.

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Sep 23, 2022

List of 1.5 things to handle. As these are addressed, put a check mark and edit this comment to indicate which PR addressed the issue:

Needs new issue

  • Deprecated allowing dtype='datetime64' or dtype=np.datetime64 in Series.astype()

Complete

@bashtage
Copy link
Contributor

Deprecated allowing dtype='datetime64' or dtype=np.datetime64 in Series.astype()

Is it possible to actually do this? I don't see how it could be done give the type is S1 | _str | type[Scalar] so "datetime64" would match "str", which is needed for many NumPy types (e.g., "i4", "f8").

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Sep 27, 2022

Deprecated allowing dtype='datetime64' or dtype=np.datetime64 in Series.astype()

Is it possible to actually do this? I don't see how it could be done give the type is S1 | _str | type[Scalar] so "datetime64" would match "str", which is needed for many NumPy types (e.g., "i4", "f8").

I think the type for astype() is too wide. Right now, you could do pd.Series([1,2,3]).astype("foobar"), and that would be accepted from a typing standpoint. We should work on narrowing it to the set of valid strings (might be quite large), and then we could get this deprecation done.

I'm fine to hold off on this one. The list I created was just copied from the whatsnew note.

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented Oct 7, 2022

We've checked off all the issues except astype(), so created #372 for that, so closing this.

Thanks to @bashtage for all his work on this!

@Dr-Irv Dr-Irv closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants