PHPStan 1.0 and Rector 0.12 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for the failed fixtures to catch errors faster next time.
mglaman
commented
Nov 17, 2021
Comment on lines
+42
to
+52
| final protected function checkClassTypeHasTrait(?Class_ $class, string $trait): bool | ||
| { | ||
| if ($class === null) { | ||
| return false; | ||
| } | ||
| $className = $this->nodeNameResolver->getName($class); | ||
| return in_array( | ||
| $trait, | ||
| $this->getTraitsByClass($className) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Previously the code was just checking if the class name was an empty string. Now Rector leverages a type object lookup. This helps keep code clean when checking if a class node has a trait.
| @@ -0,0 +1,17 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Adds a stub so we can unit test the GetMockBase rector set.
| @@ -6,7 +6,7 @@ | |||
| use Rector\Testing\PHPUnit\AbstractRectorTestCase; | |||
| use Symplify\SmartFileSystem\SmartFileInfo; | |||
|
|
|||
| class AssertHeaderRectorTest extends AbstractRectorTestCase { | |||
| class AssertPatternRectorTest extends AbstractRectorTestCase { | |||
There was a problem hiding this comment.
Fix for autoloading and Composer warning.
mglaman
commented
Nov 18, 2021
Comment on lines
+9
to
+16
| class GetMockRectorTest extends AbstractRectorTestCase { | ||
|
|
||
| /** | ||
| * @dataProvider provideData() | ||
| */ | ||
| public function test(SmartFileInfo $fileInfo): void | ||
| { | ||
| $this->doTestFileInfo($fileInfo); |
There was a problem hiding this comment.
This was one of the Rector rules crashing due to upstream changes. So I added a Unit test as well so we can more easily catch them without running the full functional test.
Closed
navneet0693
approved these changes
Nov 18, 2021
FlorentTorregrosa
approved these changes
Nov 18, 2021
navneet0693
added a commit
to goalgorilla/drupal_social
that referenced
this pull request
Nov 19, 2021
…added stable tag in favor of new release. 1. The PR palantirnet/drupal-rector#185 was merged. 2. See: https://github.com/palantirnet/drupal-rector/releases/tag/0.12.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends #184 with fixes to base classes.
I would recommend tagging 0.12.0 for this commit, following the release version pattern of Rector
Drupal.org issue
https://www.drupal.org/project/rector/issues/3248684