Updating dependencies in favor of Drupal 9 compatiblity #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added "drupal/core-dev" for enabling PHPUnit tests. See: https://www.drupal.org/docs/develop/using-composer/starting-a-site-using-drupal-composer-project-templates#s-adding-drupalcore-dev 2. Updated "drupal/drupal-extension" to "^4.1". And removed other behat dependencies as they will be installed with drupal-extension. 3. Update "phpunit/phpunit" to "^9.1". See: https://www.drupal.org/project/drupal/issues/3127141 4. Removed symfony/css-selector as it will installed as dependency of symfony/http-kernel
navneet0693
requested review from
ronaldtebrake and
Kingdutch
and removed request for
ronaldtebrake
navneet0693
force-pushed
the
feature/opensocial-11
branch
from
ee831c5 to
f75074a
Compare
1. Also because of Drupal 9 requirement's for database. 2. See: https://www.drupal.org/docs/understanding-drupal/how-drupal-9-was-made-and-what-is-included/environment-requirements-of-drupal-9#s-database-backend-and-other-hosting-requirements
1. See: https://www.drupal.org/docs/upgrading-drupal/how-to-prepare-your-drupal-7-or-8-site-for-drupal-9/upgrading-a-drupal-8-site 2. See: https://www.drupal.org/docs/updating-drupal/how-to-prepare-your-drupal-7-or-8-site-for-drupal-9/deprecation-checking-and#s-use-the-drupal-8-branch-of-upgrade-status-for-full-site-reporting. 3. Removing mglaman/drupal-check in favor of mglaman/phpstan-drupal with phpstan/extension-installer and phpstan/phpstan-deprecation-rules. 4. See: https://drupal.slack.com/archives/CDDD98AMN/p1636715151099300.
navneet0693
force-pushed
the
feature/opensocial-11
branch
from
a45ffcd to
d4831f2
Compare
It fixes the conflicts with phpstan-drupal due to PHPStan versions. This fork resolves the conflicts.
navneet0693
added a commit
to goalgorilla/open_social_docker
that referenced
this pull request
Nov 19, 2021
1. Added composer.json similar to goalgorilla/drupal_social#362 2. Extends image from Drupal 9.1 3. Changed the way composer install command runs.
navneet0693
added a commit
to goalgorilla/open_social_docker
that referenced
this pull request
Nov 19, 2021
1. Added a new folder which will serve the purpose of doing D9 readiness development leaving the regular docker machines as it is. 2. Added composer.json similar to goalgorilla/drupal_social#362 3. Extends image from Drupal 9.1 4. Changed the way composer install command runs.
…added stable tag in favor of new release. 1. The PR palantirnet/drupal-rector#185 was merged. 2. See: https://github.com/palantirnet/drupal-rector/releases/tag/0.12.0
1. Changed dev to d9 tag for docker image. 2. Added Solr 8 configuration. 3. Upgraded selenium/standalone-firefox-debug image to install.
navneet0693
force-pushed
the
feature/opensocial-11
branch
from
bc96cd0 to
ed990f0
Compare
Kingdutch
reviewed
Dec 13, 2021
Comment on lines
+76
to
+81
| "scripts": { | ||
| "refresh": [ | ||
| "rm -rf composer.lock vendor html/core html/modules/contrib html/profiles/contrib html/themes/contrib", | ||
| "@composer update -W --ansi" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
@navneet0693 Perhaps we can remove this since it's a command waiting for disaster for developers who do not grasp exactly what it does.
Your working copy of Open Social and themes will both be in html/*/contrib and so this command will also throw those away along with your local copy of git. This means that if you have unpushed work or unstaged changes, those changes will be gone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/node/3176567
Updated "drupal/drupal-extension" to "^4.1". And removed other behat dependencies as they will be installed with drupal-extension.
Update "phpunit/phpunit" to "^9.1". See: https://www.drupal.org/project/drupal/issues/3127141
Removed symfony/css-selector as it will installed as dependency of symfony/http-kernel
Removed "roave/security-advisories" in favor of https://www.drupal.org/project/drupal/issues/3124260.
Composer migration guides: