Add grouped imports by default in tslint:all

[VincentLanglet]

Overview of change:

The tslint:all config seems to be used in order to activate all the rules and to be the strictest possible.
"grouped-imports":true is stricter than "grouped-imports":false

CHANGELOG.md entry:

[enhancement] add grouped import in the all config

[VincentLanglet]

BTW, since ordered imports is used in tslint:recommended.
Should we add the grouped imports option ?

[adidahiya]

overall this change seems fine, but see my comment below.

no, we shouldn't change tslint:recommended, since that configuration follows semver (see configuration docs)

[adidahiya]

was this newline added by the grouped-imports option? what's the logic here? it seems to separate the different levels of imports into groups in some places, but not in others (e.g. in exclusionFactory.ts, ../../ imports are in the same group as ../ imports). I haven't been following this rule closely, but that behavior is a little surprising to me and I'd like to revisit it before enabling this rule in tslint:all.

[VincentLanglet]

Yes. There is 3 différents levels: libraries, parents folder and same folder.

import something from "module"

import foo from "../../foo"
import bar from "../bar"

import baz from "./baz"

[adidahiya]

ok, the documentation for "grouped-imports" is pretty light, so I'd like to see it expanded before merging this, at the very least for other TSLint contributors so they know what to expect from this rule when working on the TSLint code base.

[VincentLanglet]

@adidahiya
The first time I read this rules I found it pretty clear, there is a similar rule for eslint. I can add a commit with more explanation for the rule, but what did you not understood with the existing following explanation ?

you can enforce a grouping of third-party, parent directories and the current directory.

Group source imports by "bar", "../baz", "./foo".

[VincentLanglet]

Hi @adidahiya, could you be more explicit about the lack of documentation ?
I consider the actual pretty clear, and there is a fixer. I'll be happy to add something if you need it.

Thanks

[adidahiya]

with #4134 merged, the docs are now in a better place. I'll merge this and resolve any conflicts on master