Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Mention file names in script parse failures (#4381) #4397

Merged
merged 3 commits into from
Jan 9, 2019

Conversation

aprilrd
Copy link
Contributor

@aprilrd aprilrd commented Dec 19, 2018

PR checklist

Overview of change:

I added more tests on the changes in this PR: #4390

Is there anything you'd like reviewers to focus on?

Please check if the tests are idiomatic for the project

CHANGELOG.md entry:

[enhancement] Mention file names in test script parse failures

@aprilrd aprilrd changed the title Parse line file name Mention file names in script parse failures (#4381) Dec 19, 2018
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just the comment on the test.

test/rule-tester/linesTests.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @aprilrd! This'll be really nice when authoring rules...

@adidahiya adidahiya merged commit cda471e into palantir:master Jan 9, 2019
adidahiya pushed a commit that referenced this pull request Jan 10, 2019
ColCh added a commit to ColCh/tslint that referenced this pull request Feb 3, 2019
* master: (60 commits)
  Added tslint-brunch to the list of 3rd party tools (palantir#4251)
  Switch to tslint-plugin-prettier, clean up rule options config syntax (palantir#4488)
  Enable grouped-imports for ordered-imports rule in tslint:all config (palantir#4420)
  Ordered imports grouping (palantir#4134)
  trailing-comma: check for a closing parenthesis (palantir#4457)
  Update index.md (palantir#4473)
  [bugfix] `no-unsafe-any`: allow implicitly downcasting `any` to `unknown` (palantir#4442)
  Add v5.12.1 changelog
  Bump version to 5.12.1
  Fix quotemark avoid-template issues (palantir#4408)
  Skip linting JSON files entirely (palantir#4001)
  Fix strict-type-predicate for unknown (palantir#4444)
  restrict increment-decrement fixer while fixing the postfix unary expressions (palantir#4415)
  Mention file names in script parse failures (palantir#4397)
  Revert breaking change to tslint:recommended, update tslint:latest (palantir#4404)
  Fix quotemark avoid-template issues (palantir#4408)
  Bump tslint dev dependency to 5.12.0 (palantir#4452)
  Skip linting JSON files entirely (palantir#4001)
  Fix strict-type-predicate for unknown (palantir#4444)
  [README] Update link for Webstorm (palantir#4450)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention file name when a test fails to parse error markers
3 participants