This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Set --lib es6, and use Map/Set methods where possible.
#1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-hanson
force-pushed
the
es6
branch
2 times, most recently
from
ba5787c to
5e72879
Compare
andy-hanson
commented
Jan 5, 2017
| this.addFailureAtNode(node, Rule.FAILURE_STRING); | ||
| } | ||
| const isNumber = node.kind === ts.SyntaxKind.NumericLiteral && !Rule.ALLOWED_NODES.has(node.parent!.kind); | ||
| const isMagicNumber = (isNumber || isUnary) && !this.allowed.has(node.getText()); |
There was a problem hiding this comment.
Seems like the isUnary case should also check for ALLOWED_NODES, but this is what it did before.
ajafff
reviewed
Jan 5, 2017
|
|
||
| class PreferForOfWalker extends Lint.BlockScopeAwareRuleWalker<{}, IncrementorMap> { | ||
| public createScope() { | ||
| return {}; | ||
| return new Map(); |
There was a problem hiding this comment.
this method could just return void (need to update type parameters). scope is never used anywhere, only blockScope is needed.
5 tasks
nchen63
approved these changes
Jan 7, 2017
| @@ -21,11 +21,10 @@ import {IOptions} from "../rule/rule"; | |||
| import {RuleWalker} from "./ruleWalker"; | |||
|
|
|||
| export class SkippableTokenAwareRuleWalker extends RuleWalker { | |||
| protected tokensToSkipStartEndMap: {[start: number]: number}; | |||
| private tokensToSkipStartEndMap = new Map<number, number>(); | |||
|
|
|||
| constructor(sourceFile: ts.SourceFile, options: IOptions) { | |||
There was a problem hiding this comment.
don't need constructor anymore
| this.addFailureAtNode(node, Rule.FAILURE_STRING); | ||
| } | ||
| const isNumber = node.kind === ts.SyntaxKind.NumericLiteral && !Rule.ALLOWED_NODES.has(node.parent!.kind); | ||
| const isMagicNumber = (isNumber || isUnary) && !this.allowed.has(node.getText()); |
|
@andy-hanson thanks! |
|
this is an awesome PR, thanks @andy-hanson |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What changes did you make?
Set the
"lib"option to["es6", "dom"]("dom" typings used by underscore).EDIT: Removed underscore; it's only used by 1 function,
camelize, that's a one-liner. Their source, mine.Used
MapandSetin cases where their absence appeared to have been compensated for.Is there anything you'd like reviewers to focus on?
It's more efficient to lookup in a Map only once, so avoid this pattern:
Prefer: