This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

`no-magic-numbers` doesn't ignore special nodes for negative #s #2005

Closed

nchen63 opened this issue Jan 7, 2017 · 0 comments · Fixed by #2035

Assignees

Labels

Contributor

nchen63 commented Jan 7, 2017

This fails, but it shouldn't because it's an export node:
export let x = -4;

also, rename isUnary in that class to isNegativeNumber

The text was updated successfully, but these errors were encountered:

nchen63 added Status: Accepting PRs Type: Bug and removed Status: Accepting PRs labels

nchen63 self-assigned this

nchen63 mentioned this issue

Set --lib es6, and use Map/Set methods where possible. #1984

Merged

5 tasks

nchen63 mentioned this issue

no-magic-numbers: negative numbers fail even if in allowed node #2035

Merged

nchen63 closed this as completed in #2035

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.