Require semicolon for type alias

[ghost]

This would require all type t = foo; to end with a semicolon.

[adidahiya]

👍 thanks @andy-ms!

[jkillian]

Hmm, this also is a breaking change, we should either (temporarily) revert this, or just start merging other breaking changes for 4.0

[ScottSWu]

Oops, looking at the log, it looks like the new tests are just missing in the test.ts.fix files added with suggesting fixes.

[ghost]

I noticed that the .fix files have CRLF line endings while the .lint files have LF line endings, at least on my checkout. I was able to get tests working by adding results.fixesFromMarkup = results.fixesFromMarkup.replace(/\r\n/g, "\n"); to consoleTestResultHandler in test.ts (and by adding the missing type t = number; lines), but there is likely a better solution.

[ScottSWu]

Interesting, it looks like diff.diffLines does consider both line endings, but only ignores them in the diff if {newlineIsToken: true} is specified. That argument isn't in the typings file, but is implemented.

[jkillian]

Hmm, I'm confused why the Circle build didn't break as well, considering the .fix files didn't change?

Looks like the diff options you mentioned are documented though, so I'm happy to use them in our code: https://github.com/kpdecker/jsdiff#api

[jkillian]

Going to revert this PR temporarily for now (#1477), but we'll get it back in for 4.0

[ghost]

Should I make a second PR with test fixes?

[jkillian]

I'm not sure if I can "re-open" a merged PR on GH, so a new one would be great!

[jkillian]

#1478 created which adjusts the appropriate .fix files. @ScottSWu - have any idea why the CircleCI build passed on this PR in the first place?

[ghost]

The branch I had didn't have the .fix files on it at all, as it was out-of-date with the latest master. So a CI that just ran the contents of my branch (and not the potential merged contents) would succeed.

[jkillian]

Ohh, I didn't realize it was off an out of date master, that makes perfect sense. I guess the underlying issue here then is to get CircleCI to run the tests on the result of the would-be-merge as well.

[jkillian]

Seems as if CircleCI doesn't support this unfortunately.