Require semicolons for type aliases (#1475)

palantir · Aug 11, 2016 · 6f3d73b · 6f3d73b
1 parent 26b152b
commit 6f3d73b
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 0 deletions.
diff --git a/src/language/walker/syntaxWalker.ts b/src/language/walker/syntaxWalker.ts
@@ -286,6 +286,10 @@ export class SyntaxWalker {
         this.walkChildren(node);
     }
 
+    protected visitTypeAliasDeclaration(node: ts.TypeAliasDeclaration) {
+        this.walkChildren(node);
+    }
+
     protected visitTypeAssertionExpression(node: ts.TypeAssertion) {
         this.walkChildren(node);
     }
@@ -584,6 +588,10 @@ export class SyntaxWalker {
                 this.visitTryStatement(<ts.TryStatement> node);
                 break;
 
+            case ts.SyntaxKind.TypeAliasDeclaration:
+                this.visitTypeAliasDeclaration(<ts.TypeAliasDeclaration> node);
+                break;
+
             case ts.SyntaxKind.TypeAssertionExpression:
                 this.visitTypeAssertionExpression(<ts.TypeAssertion> node);
                 break;

diff --git a/src/rules/semicolonRule.ts b/src/rules/semicolonRule.ts
@@ -140,6 +140,11 @@ class SemicolonWalker extends Lint.RuleWalker {
         super.visitExportAssignment(node);
     }
 
+    public visitTypeAliasDeclaration(node: ts.TypeAliasDeclaration) {
+        this.checkSemicolonAt(node);
+        super.visitTypeAliasDeclaration(node);
+    }
+
     private checkSemicolonAt(node: ts.Node) {
         const sourceFile = this.getSourceFile();
         const children = node.getChildren(sourceFile);

diff --git a/test/rules/semicolon/always/test.ts.lint b/test/rules/semicolon/always/test.ts.lint
@@ -84,3 +84,6 @@ export = Date;
 export = Date
              ~nil [Missing semicolon]
 
+type t = number;
+type t = number
+               ~nil [Missing semicolon]
diff --git a/test/rules/semicolon/enabled/test.ts.lint b/test/rules/semicolon/enabled/test.ts.lint
@@ -83,3 +83,7 @@ export default LoginPage
 export = Date;
 export = Date
              ~nil [Missing semicolon]
+
+type t = number;
+type t = number
+               ~nil [Missing semicolon]
diff --git a/test/rules/semicolon/ignore-interfaces/test.ts.lint b/test/rules/semicolon/ignore-interfaces/test.ts.lint
@@ -83,3 +83,7 @@ export default LoginPage
 export = Date;
 export = Date
              ~nil [Missing semicolon]
+
+type t = number;
+type t = number
+               ~nil [Missing semicolon]
diff --git a/test/rules/semicolon/never/test.ts.lint b/test/rules/semicolon/never/test.ts.lint
@@ -116,3 +116,7 @@ export default LoginPage
 export = Date;
              ~ [Unnecessary semicolon]
 export = Date
+
+type t = number;
+               ~ [Unnecessary semicolon]
+type t = number