This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Adding new rule to disallow non consecutive function overloads #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakatyal
force-pushed
the
raghav/overload
branch
from
2f74975
to
7fcf7eb
Compare
| optionsDescription: "Not configurable.", | ||
| options: null, | ||
| optionExamples: ["true"], | ||
| type: "style", |
There was a problem hiding this comment.
let's change this to "typescript" since it's typescript-specific
|
Thanks for the PR @rakatyal, in general I like the idea of this rule. Needs some small tweaks and additional tests before merging. |
|
@adidahiya: Thanks for the detailed review. I have refactored the code according to your suggestions and to handle the case for nested interfaces. Please have a look again. |
|
lgtm 👍 |
soniro
pushed a commit
to soniro/tslint
that referenced
this pull request
Aug 31, 2016
This was referenced Nov 11, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.