Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tslint rule to enforce consecutive function overloads #9581

Closed
wants to merge 4 commits into from
Closed

Adding tslint rule to enforce consecutive function overloads #9581

wants to merge 4 commits into from

Conversation

rakatyal
Copy link

@rakatyal rakatyal commented Jul 9, 2016

Fixes #

@msftclas
Copy link

msftclas commented Jul 9, 2016

Hi @rakatyal, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Raghav Katyal). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

mhegazy
mhegazy reviewed Jul 9, 2016
View reviewed changes
scripts/tslint/enforceConsecutiveFunctionOverloadRule.ts
visitInterfaceDeclaration(node: ts.InterfaceDeclaration): void {
const members = node.members;
for (const member of members) {
if (member.name != undefined && member.name.kind === ts.SyntaxKind.Identifier) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about computed properties?

RyanCavanaugh
RyanCavanaugh reviewed Jul 14, 2016
View reviewed changes
scripts/tslint/enforceConsecutiveFunctionOverloadRule.ts
@@ -10,6 +10,26 @@ export class Rule extends Lint.Rules.AbstractRule {
}
}

function isStringOrNumericLiteral(kind: number) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ts.SyntaxKind.StringLiteral etc instead of 9 / 8 and have kind: ts.SyntaxKind

@ghost
Copy link

ghost commented Nov 11, 2016

This became palantir/tslint#1426, so closing here.

@ghost ghost closed this Nov 11, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rakatyal @msftclas @RyanCavanaugh @mhegazy