Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump codahale metrics #309

Closed
wants to merge 1 commit into from
Closed

Bump codahale metrics #309

wants to merge 1 commit into from

Conversation

bkrieger
Copy link

@bkrieger bkrieger commented Feb 7, 2018

Bumping the version of codahale metrics from 3.2.5 to 4.0.2

@robert3005
Copy link

We can't do this outside of major version since this is mostly used as a library. All the other bumps I have done in this repo are only for minor versions. As you can see from circle logs it's not as trivial as just bumping the version

@bkrieger
Copy link
Author

bkrieger commented Feb 8, 2018

Ok, closing.

@bkrieger bkrieger closed this Feb 8, 2018
@bkrieger bkrieger deleted the bkrieger-patch-1 branch February 8, 2018 15:47
@schlosna
Copy link

schlosna commented Feb 8, 2018

@bkrieger curious, was there something specific you were looking to use in metrics 4.0? Agree with Rob that this would possibly cause downstream chaos, so probably want to think through consequences & tradeoffs before upgrading in libs.

From https://github.com/dropwizard/metrics/releases main changes look like:

@bkrieger
Copy link
Author

bkrieger commented Feb 8, 2018

There's nothing specific I want; I have another library that depends on 4.x and I wanted to use that library and Spark in the same application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants