-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ts version and webpack version #184
Changes from 3 commits
43a4ddb
94a247c
5f8e460
5ce96e1
2b2ed9d
e629bca
50dd8ea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
type: improvement | ||
improvement: | ||
description: Upgrade typescript/webpack versions | ||
links: | ||
- https://github.com/palantir/conjure-typescript/pull/184 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -186,8 +186,8 @@ describe("generate command", () => { | |
expect(fs.existsSync(path.join(outDir, "node_modules/typescript/bin/tsc"))); | ||
}); | ||
|
||
jest.setTimeout(10000); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do we move this out of the test case? seems like other test cases still set the timeout explicitly There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had a similar issue as jestjs/jest#11543 it's simply ignored, I should probably spend more time looking into it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lifted this up to the top level describe and removed from each individual test, are you ok with that? |
||
it("generated code compiles", async () => { | ||
jest.setTimeout(10000); | ||
await generateCommand.handler({ | ||
_: ["generate", input, outDir], | ||
packageName: "foo", | ||
|
@@ -242,7 +242,7 @@ describe("generate command", () => { | |
const child = child_process.exec(command, { cwd }); | ||
child.on("error", reject); | ||
child.on("exit", code => { | ||
resolve(code); | ||
resolve(code || 0); | ||
}); | ||
}); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran the jest migration script to update this file - it seems to work fine!