Upgrade ts version and webpack version #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
| ], | ||
| verbose: true, | ||
| }; | ||
| preset: 'ts-jest/presets/js-with-ts', | ||
| } |
There was a problem hiding this comment.
ran the jest migration script to update this file - it seems to work fine!
ferozco
reviewed
Nov 24, 2021
| @@ -186,8 +186,8 @@ describe("generate command", () => { | |||
| expect(fs.existsSync(path.join(outDir, "node_modules/typescript/bin/tsc"))); | |||
| }); | |||
|
|
|||
| jest.setTimeout(10000); | |||
There was a problem hiding this comment.
why do we move this out of the test case? seems like other test cases still set the timeout explicitly
There was a problem hiding this comment.
I had a similar issue as jestjs/jest#11543 it's simply ignored, I should probably spend more time looking into it
There was a problem hiding this comment.
lifted this up to the top level describe and removed from each individual test, are you ok with that?
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of #181
As discussed with @ferozco let's release these changes first
Before this PR
outdated version of TS and webpack version
After this PR
updated version of TS/webpack
==COMMIT_MSG==
Upgrade typescript/webpack versions
==COMMIT_MSG==
Possible downsides?