Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more CSS classes in JS #691

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Expose more CSS classes in JS #691

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a475bf
Add more to Classes
Feb 16, 2017
c52cd6b
Add a new section for text utilities
Feb 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/core/src/common/classes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export const FIXED = "pt-fixed";
export const FIXED_TOP = "pt-fixed-top";
export const VERTICAL = "pt-vertical";
export const ROUND = "pt-round";
export const TEXT_OVERFLOW_ELLIPSIS = "pt-text-overflow-ellipsis";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a modifier, more like a utility class. I'll let @giladgray confirm!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create a new section:

...
export const ROUND = "pt-round";

// text utilities
export const TEXT_OVERFLOW_ELLIPSIS = "pt-text-overflow-ellipsis";

// components
...

Copy link
Contributor

@cmslewis cmslewis Feb 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palantir/blueprint Should we just put every CSS API class into this file? I'm thinking we might as well (EDIT: not in this PR, in a new one).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to get autocomplete for the other ones in the typography. If we're doing one, no reason not to do the others too if we're maintaining this file


// components
export const ALERT = "pt-alert";
Expand Down Expand Up @@ -179,6 +180,7 @@ export const TREE_NODE_SECONDARY_LABEL = "pt-tree-node-secondary-label";
export const TREE_NODE_SELECTED = "pt-tree-node-selected";
export const TREE_ROOT = "pt-tree-root";

export const ICON = "pt-icon";
export const ICON_STANDARD = "pt-icon-standard";
export const ICON_LARGE = "pt-icon-large";

Expand Down