Expose more CSS classes in JS #691
Conversation
|
Thanks for your interest in palantir/blueprint, @tgreenwatts! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
packages/core/src/common/classes.ts
Outdated
| @@ -24,6 +24,7 @@ export const FIXED = "pt-fixed"; | |||
| export const FIXED_TOP = "pt-fixed-top"; | |||
| export const VERTICAL = "pt-vertical"; | |||
| export const ROUND = "pt-round"; | |||
| export const TEXT_OVERFLOW_ELLIPSIS = "pt-text-overflow-ellipsis"; | |||
There was a problem hiding this comment.
I don't think this is a modifier, more like a utility class. I'll let @giladgray confirm!
There was a problem hiding this comment.
I would create a new section:
...
export const ROUND = "pt-round";
// text utilities
export const TEXT_OVERFLOW_ELLIPSIS = "pt-text-overflow-ellipsis";
// components
...
There was a problem hiding this comment.
@palantir/blueprint Should we just put every CSS API class into this file? I'm thinking we might as well (EDIT: not in this PR, in a new one).
There was a problem hiding this comment.
It would be useful to get autocomplete for the other ones in the typography. If we're doing one, no reason not to do the others too if we're maintaining this file
packages/core/src/common/classes.ts
Outdated
| @@ -24,6 +24,7 @@ export const FIXED = "pt-fixed"; | |||
| export const FIXED_TOP = "pt-fixed-top"; | |||
| export const VERTICAL = "pt-vertical"; | |||
| export const ROUND = "pt-round"; | |||
| export const TEXT_OVERFLOW_ELLIPSIS = "pt-text-overflow-ellipsis"; | |||
There was a problem hiding this comment.
I would create a new section:
...
export const ROUND = "pt-round";
// text utilities
export const TEXT_OVERFLOW_ELLIPSIS = "pt-text-overflow-ellipsis";
// components
...
|
Thanks @adidahiya for merging while I was ooto! |
Fixes #0000
Checklist
Changes proposed in this pull request:
Add
pt-iconandpt-text-overflow-ellipsistoClassesReviewers should focus on:
Not sure if
pt-text-overflow-ellipsisshould be considered a "modifier" or in a new category@giladgray for review