Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add popper modifier classnames #5109

Merged
merged 1 commit into from
Jan 28, 2022
Merged

feat: Add popper modifier classnames #5109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/common/classes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ export const POPOVER_CONTENT_SIZING = `${POPOVER_CONTENT}-sizing`;
export const POPOVER_DISMISS = `${POPOVER}-dismiss`;
export const POPOVER_DISMISS_OVERRIDE = `${POPOVER_DISMISS}-override`;
export const POPOVER_OPEN = `${POPOVER}-open`;
export const POPOVER_OUT_OF_BOUNDARIES = `${POPOVER}-out-of-boundaries`;
export const POPOVER_TARGET = `${POPOVER}-target`;
export const POPOVER_WRAPPER = `${POPOVER}-wrapper`;
export const TRANSITION_CONTAINER = `${NS}-transition-container`;
Expand Down
1 change: 1 addition & 0 deletions packages/core/src/components/popover/popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ export class Popover extends AbstractPureComponent2<IPopoverProps, IPopoverState
[Classes.DARK]: this.props.inheritDarkTheme && this.state.hasDarkParent,
[Classes.MINIMAL]: this.props.minimal,
[Classes.POPOVER_CAPTURING_DISMISS]: this.props.captureDismiss,
[Classes.POPOVER_OUT_OF_BOUNDARIES]: popperProps.outOfBoundaries === true,
},
this.props.popoverClassName,
);
Expand Down
2 changes: 2 additions & 0 deletions packages/popover2/src/classes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ export const POPOVER2_CONTENT_SIZING = `${POPOVER2_CONTENT}-sizing`;
export const POPOVER2_DISMISS = `${POPOVER2}-dismiss`;
export const POPOVER2_DISMISS_OVERRIDE = `${POPOVER2_DISMISS}-override`;
export const POPOVER2_OPEN = `${POPOVER2}-open`;
export const POPOVER2_POPPER_ESCAPED = `${POPOVER2}-popper-escaped`;
export const POPOVER2_REFERENCE_HIDDEN = `${POPOVER2}-reference-hidden`;
export const POPOVER2_TARGET = `${POPOVER2}-target`;
export const POPOVER2_TRANSITION_CONTAINER = `${POPOVER2}-transition-container`;

Expand Down
2 changes: 2 additions & 0 deletions packages/popover2/src/popover2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,8 @@ export class Popover2<T> extends AbstractPureComponent2<Popover2Props<T>, IPopov
[CoreClasses.DARK]: this.props.inheritDarkTheme && this.state.hasDarkParent,
[CoreClasses.MINIMAL]: this.props.minimal,
[Classes.POPOVER2_CAPTURING_DISMISS]: this.props.captureDismiss,
[Classes.POPOVER2_REFERENCE_HIDDEN]: popperProps.isReferenceHidden === true,
[Classes.POPOVER2_POPPER_ESCAPED]: popperProps.hasPopperEscaped === true,
},
`${Classes.POPOVER2_CONTENT_PLACEMENT}-${basePlacement}`,
this.props.popoverClassName,
Expand Down