feat: Add popper modifier classnames #5109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This adds new classes to the popover using some of the helpful modifiers from PopperJS's hide.
These classnames can be helpful to allow consumers to hide the popper when the reference element is scrolled out of its scrolling container.
See example: https://popper.js.org/docs/v2/modifiers/hide/
For Popover (@blueprintjs/core):
.bp3-popover-out-of-boundaries
when PopperJS v1'spopperProps.outOfBoundaries
is trueFor Popover2 (@blueprintjs/popover2):
.bp3-popover-reference-hidden
when the reference element is not visible (scrolled off screen).bp3-popper-escaped
when the popper escapes the reference element's boundariesThis PR does not change any behavior other than rendering the new classnames, which have no styles applied to them by default.