Remove color rule from icon classes #493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
suggested changes
Jan 16, 2017
| @@ -19,7 +19,7 @@ export class DialogExample extends OverlayExample { | |||
| className={this.props.getTheme()} | |||
| iconName="inbox" | |||
| onClose={this.handleClose} | |||
| title="Dialog Header" | |||
| title="Dialog header" | |||
There was a problem hiding this comment.
👎 these text changes really don't belong here. would be great if you could pull them out to a separate PR so this PR contains literally only what is in the title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437
Changes proposed in this pull request:
colorrule from icon classesThis way, folks using a custom element with a custom
colorwon't have issues with icons showing up gray.