Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default icon color #437

Closed
llorca opened this issue Jan 9, 2017 · 2 comments
Closed

Remove default icon color #437

llorca opened this issue Jan 9, 2017 · 2 comments

Comments

@llorca
Copy link
Contributor

llorca commented Jan 9, 2017

Icons have a color specified in every context. It has caused some trouble in a few places, for instance when displaying text with a custom color (e.g. green or red) and adding an icon to it, the icon would remain grey.

Note that this change would make icons slightly darker since they'd follow the default body text color.

@pkwi what do you think about this change?

@cmslewis
Copy link
Contributor

Yessss. This change bit me (minorly) in a past project.

@pkwi
Copy link
Contributor

pkwi commented Jan 11, 2017

Currently, icons are using 'muted' text colour. I'm not a fan of making them the same colour as the default text. Because of solid style, in some cases, they would appear darker and more dominant than the text next to it. Using a lighter colour help to tone down the contrast.
We could remove the default colour and strongly recommend using a muted text class for icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants