Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IP-301] GetSubscriptionFeed Add service subscription check on profile unsubscription #144

Merged

Conversation

AleDore
Copy link
Contributor

@AleDore AleDore commented Jul 8, 2021

User that enables a single service after switching to MANUAL mode, must be tracked on Subscription Feed because Profile Unsubscription is not related only to a Profile deletion.

List of Changes

  • GetSubscriptioFeed evaluate service subscription while it reads a profile unsubscription
  • Update test

Motivation and Context

It solves a data inconsistence if User enables a single service after switching to MANUAL mode in the same day.

How Has This Been Tested?

Unit tested

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pagopa-github-bot
Copy link
Contributor

Warnings
⚠️

Please include a Pivotal story at the beginning of the PR title (see below).

Example of PR titles that include pivotal stories:

  • single story: [#123456] my PR title
  • multiple stories: [#123456,#123457,#123458] my PR title

Generated by 🚫 dangerJS

Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleDore AleDore merged commit d8e20c7 into master Jul 8, 2021
@AleDore AleDore deleted the IP-301_add_service_subscription_check_on_subscription_feed branch July 8, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants