Add service subscription check (#144)

pagopa · Jul 8, 2021 · d8e20c7 · d8e20c7
1 parent a587b98
commit d8e20c7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/GetSubscriptionsFeed/__tests__/handler.test.ts b/GetSubscriptionsFeed/__tests__/handler.test.ts
@@ -256,7 +256,7 @@ describe("GetSubscriptionsFeedHandler", () => {
     // service subscriptions
     queryEntities.mockImplementationOnce(
       queryEntitiesServiceSubscriptionMock(
-        [anHashedFiscalCode, anotherHashedFiscalCode],
+        [anHashedFiscalCode],
         "S"
       )
     );
@@ -283,7 +283,7 @@ describe("GetSubscriptionsFeedHandler", () => {
       expect(result.value).toEqual({
         dateUTC: yesterdayUTC,
         subscriptions: [],
-        unsubscriptions: [anHashedFiscalCode, anotherHashedFiscalCode]
+        unsubscriptions: [anotherHashedFiscalCode]
       });
     }
   });

diff --git a/GetSubscriptionsFeed/handler.ts b/GetSubscriptionsFeed/handler.ts
@@ -174,11 +174,14 @@ export function GetSubscriptionsFeedHandler(
 
     const unsubscriptions = new Array<FiscalCodeHash>();
 
-    profileUnsubscriptionsSet.forEach(pu =>
-      // add all users that deleted its own account
-      // eslint-disable-next-line functional/immutable-data
-      unsubscriptions.push(pu)
-    );
+    profileUnsubscriptionsSet.forEach(pu => {
+      if (!serviceSubscriptionsSet.has(pu)) {
+        // add all users that deleted its own account skipping those that
+        // subscribed to this service
+        // eslint-disable-next-line functional/immutable-data
+        unsubscriptions.push(pu);
+      }
+    });
 
     serviceUnsubscriptionsSet.forEach(su => {
       if (