fix: sync lock should be released only if we're retrying (argoproj#9063)

Signed-off-by: Julie Vogelman <[email protected]>
Signed-off-by: Loric ANDRE <[email protected]>

workflow/controller/operator.go

@@ -1895,15 +1895,14 @@ func (woc *wfOperationCtx) executeTemplate(ctx context.Context, nodeName string,
 	if err != nil {
 		node = woc.markNodeError(nodeName, err)
 
-		woc.controller.syncManager.Release(woc.wf, node.ID, processedTmpl.Synchronization)
-
 		// If retry policy is not set, or if it is not set to Always or OnError, we won't attempt to retry an errored container
 		// and we return instead.
 		retryStrategy := woc.retryStrategy(processedTmpl)
 		if retryStrategy == nil ||
 			(retryStrategy.RetryPolicy != wfv1.RetryPolicyAlways &&
 				retryStrategy.RetryPolicy != wfv1.RetryPolicyOnError &&
 				retryStrategy.RetryPolicy != wfv1.RetryPolicyOnTransientError) {
+			woc.controller.syncManager.Release(woc.wf, node.ID, processedTmpl.Synchronization)
 			return node, err
 		}
 	}