fix: sync lock should be released only if we're retrying #9063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <[email protected]>
sarabala1979
approved these changes
Jun 29, 2022
LoricAndre
pushed a commit
to padoa/argo-workflows
that referenced
this pull request
Aug 1, 2022
Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: Loric ANDRE <[email protected]>
|
If I am not mistaken, does that mean that a sleeping task during a retry back off will hold the lock, whereas it does not do any work? |
3 tasks
Closed
reddymh
pushed a commit
to reddymh/argo-workflows
that referenced
this pull request
Jan 2, 2023
Signed-off-by: Julie Vogelman <[email protected]> Signed-off-by: Reddy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Julie Vogelman [email protected]
We shouldn't be performing this release logic except in the case of our returning.