feat: Truncate tags in UI when they are super long #513
Conversation
| @@ -254,7 +256,7 @@ def base_url | |||
| def pact_tags | |||
| @relationship.tag_names.map do |tag| | |||
| { | |||
| name: tag, | |||
| name: tag.ellipsisize, | |||
There was a problem hiding this comment.
Truncate it in the server and let the UI render it.
Another option is to truncate it in UI using JS.
My pref is to truncate at server side to keep it consistent on how tags are currently handled/rendered.
How do you reckon?
There was a problem hiding this comment.
Yes. This is the spot that returns the tag names though.
That's code is for the menu.There was a problem hiding this comment.
I always miss something in my PR :face_palm:. Will make a change. Thanks for pointing out Beth.
There was a problem hiding this comment.
Fixed. Please have another look when you have time :D
|
This is to address issue #397 |
|
That bit is looking much better now.
Could you apply the same to this screen:
And this screen?
We truncate the version number already, and provide a "copy" button next to it so that the user can easily get the full number to paste into other tools if they need to. Could you have a look at doing that? Maybe the ellipsisize should be called in the HAML, because then you'll have the full value to make the copy button with, and the truncated value. |
|
I've fixed the mysql tests, btw, if you want to merge from master. |
That sounds good. I'll do it that way then |
|
Looking good. Strange those tests are failing though. |
|
Just checking you're not waiting on me for anything. Looking forward to merging this when you've got the tests passing. |
|
Hi Beth sorry I was busy lately. Will look into it next week 🙂 |
bangn
force-pushed
the
issue-397
branch
2 times, most recently
from
3cbf433 to
6fe4073
Compare
|
Hey Beth, I have fixed the spec and squash the commits into one. Please let me know if you need me to do anything else |
bangn
force-pushed
the
issue-397
branch
2 times, most recently
from
e156504 to
fdff54f
Compare
|
Awesome. I'll pick it up on my next oss day. |
|
My next OSS day, which I have not had for what seems like months. So sorry this hasn't been merged yet. |
|
Haha. It's all good.
…On Fri, 17 Dec 2021, 12:00 Beth Skurrie, ***@***.***> wrote:
My next OSS day, which I have not had for what seems like months. So sorry
this hasn't been merged yet.
—
Reply to this email directly, view it on GitHub
<#513 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABF3UL5BOO3C2AE6X3BKAE3URKDRVANCNFSM5FOUN7QA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I'm so sorry it's taken me this long to merge. I'm so appreciative of this though! |
No description provided.