Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate tags in UI when they're super long #397

Open
bethesque opened this issue Feb 26, 2021 · 5 comments
Open

Truncate tags in UI when they're super long #397

bethesque opened this issue Feb 26, 2021 · 5 comments

Comments

@bethesque
Copy link
Member

Screen Shot 2021-02-26 at 4 45 55 pm

@stephenwang1011
Copy link

stephenwang1011 commented Feb 27, 2021

I think I have the same issue
image
And my tag should be branch name 'dev' or 'master', but I got :
build_41ofunga01amk6uvqsfp2h9hs$_run_closure14$_closure28$_closure29$_closure31@f13450a

@bethesque bethesque changed the title Concatenate tags in UI when they're super long Truncate tags in UI when they're super long Feb 28, 2021
@bethesque
Copy link
Member Author

The broker isn't making up that text! I'd have a look at the code that is setting your tag in the provider configuration.

@stephenwang1011
Copy link

stephenwang1011 commented Mar 1, 2021

pact {
    broker {
        pactBrokerUrl = System.getenv("PACT_BROKER_URL")
        pactBrokerUsername = System.getenv("PACT_BROKER_USERNAME")
        pactBrokerPassword = System.getenv("PACT_BROKER_PASSWORD")
    }

    reports {
        defaultReports()
        markdown
    }

    serviceProviders {
        NeuronPublic {
            providerVersion = { System.getenv("CIRCLE_SHA1") }
            providerTag = { System.getenv("CIRCLE_BRANCH") }
            protocol = 'http'
            host = 'xx-api-qa.xx-xx.com'
            port = 80
            path = '/'
            requestFilter = { req ->
                req.addHeader('testmode', 'true')
                req.addHeader('X-Authorization', 'Bearer ' + System.getenv("PACT_REQUEST_TOKEN"))
            }


            fromPactBroker {
                selectors = latestTags('dev')
                stateChangeUrl = url('http://xx-api-qa.xx-xx.com/api/pact/providerState')
                stateChangeUsesBody = true
                stateChangeRequestFilter = { req ->
                    req.addHeader('testmode', 'true')
                    req.addHeader('X-Authorization', 'Bearer ' + System.getenv("PACT_REQUEST_TOKEN"))
                }

            }
        }
    }
}

And my current provider branch is 'dev', so I think the tag should be 'dev', it worked fine before

@stephenwang1011
Copy link

JDK11
image

@stephenwang1011
Copy link

$ ./gradlew -d pactverify -Ppact.verifier.publishResults=true **-Dpact.provider.tag=Test2**

I used 'pact.provider.tag' instead . My issue was fixed!
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants