fix(matrix): prevent long version names overflow the table #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Just thinking, sometimes very long version numbers are the same at the start, but different at the end. How about we make this just a little smarter and include the last, I don't know, 10 chars at the end? <40 chars>...<10 chars> |
ertrzyiks
force-pushed
the
issue-510-limit-max-length-of-version
branch
from
cf2cd04 to
c2e32c5
Compare
|
@bethesque makes sense, I updated the code |
ertrzyiks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the display version number is no longer than 50 characters to avoid content overflow
Related to #510