Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix table overflow due to huge version number #510

Closed
1 of 3 tasks
ertrzyiks opened this issue Oct 4, 2021 · 5 comments
Closed
1 of 3 tasks

Matrix table overflow due to huge version number #510

ertrzyiks opened this issue Oct 4, 2021 · 5 comments

Comments

@ertrzyiks
Copy link
Contributor

ertrzyiks commented Oct 4, 2021

Pre issue-raising checklist

I have already (please mark the applicable with an x):

  • Upgraded to the latest Pact Broker OR
  • Checked the CHANGELOG to see if the issue I am about to raise has been fixed
  • Created an executable example that demonstrates the issue using either a:
    • Dockerfile
    • Git repository with a Travis or Appveyor (or similar) build

Software versions

  • pact-broker docker version: 2.79.1

Expected behaviour

Long version numbers are abbreviated

Actual behaviour

Only hash commits with 40 characters are abbreviated

Other version formats are rendered raw (We use a compound versioning scheme for the graphql gateway verification.)
Screenshot 2021-10-04 at 10 10 59

Steps to reproduce

Publish a contract using a long version string

@TimothyJones
Copy link
Contributor

Thanks for the report! I particularly enjoyed the original phrasing of "ridiculously long version number" :)

As a workaround (assuming the ridiculously long version number was in error), you could delete the version. I do agree it would be good to have this case handled in a more user friendly way, though.

@ertrzyiks
Copy link
Contributor Author

ertrzyiks commented Oct 4, 2021

I edited the description to make it look more professional as something that needs more attention than jokes. (However I still find hundreds character long version ridiculously long 😅 )

Please let me know if I can help to address this one, I came up with two ideas that I can contribute with:

  • update AbbreviateNumber to have some hard limit anyway, not only 40 -> 6 hashes
  • use fixed table-layout for matrix table so it never grows wider than 100% of the screen width

@bethesque
Copy link
Member

I think we update AbbreviateNumber. If you'd like to contribute a fix, I'm happy to assist.

@ertrzyiks
Copy link
Contributor Author

I prepared a straightforward fix in #511, please advise if we need anything else

@ertrzyiks
Copy link
Contributor Author

Fixed in 2.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants