Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger one webhook for each pact publication that the verified … #378

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

bethesque
Copy link
Member

…content belongs to when using the 'pacts for verification' API

Fixes #362

@bethesque bethesque requested review from mefellows and uglyog January 29, 2021 01:07
@bethesque bethesque force-pushed the feat/trigger-webhook-for-every-consumer-version branch from 8cd0fe1 to 9a1678b Compare January 29, 2021 01:27
@bethesque
Copy link
Member Author

Logs from the demo webmock server running this repo script https://github.com/pact-foundation/pact_broker/blob/issue/pact-broker-377/script/reproduce-issue.rb On 2.76.0.0 it only shoes one verification event. With this code, there are two.

{"eventName":"contract_published","consumerVersionNumber":"1","consumerVersionTags":"main","githubVerificationStatus":"pending","providerVersionNumber":"","providerVersionTags":""}
::1 - - [29/Jan/2021:11:56:08 +1100] "POST / HTTP/1.1" 200 18 0.0012
{"eventName":"contract_published","consumerVersionNumber":"2","consumerVersionTags":"feat/x, feat/y","githubVerificationStatus":"pending","providerVersionNumber":"","providerVersionTags":""}
::1 - - [29/Jan/2021:11:56:08 +1100] "POST / HTTP/1.1" 200 18 0.0004

{"eventName":"provider_verification_published","consumerVersionNumber":"1","consumerVersionTags":"main","githubVerificationStatus":"success","providerVersionNumber":"1","providerVersionTags":"main"}
::1 - - [29/Jan/2021:11:56:18 +1100] "POST / HTTP/1.1" 200 18 0.0004
{"eventName":"provider_verification_published","consumerVersionNumber":"2","consumerVersionTags":"feat/x, feat/y","githubVerificationStatus":"success","providerVersionNumber":"1","providerVersionTags":"main"}

…content belongs to when using the 'pacts for verification' API
@bethesque bethesque force-pushed the feat/trigger-webhook-for-every-consumer-version branch from 9a1678b to def3335 Compare January 29, 2021 02:11
@bethesque bethesque mentioned this pull request Jan 29, 2021
3 tasks
@bethesque bethesque merged commit 114ccad into master Jan 29, 2021
@bethesque bethesque deleted the feat/trigger-webhook-for-every-consumer-version branch January 29, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure verification webhooks can update the correct github status of the consumer
1 participant