Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure verification webhooks can update the correct github status of the consumer #362

Closed
bethesque opened this issue Dec 15, 2020 · 3 comments · Fixed by #378
Closed

Ensure verification webhooks can update the correct github status of the consumer #362

bethesque opened this issue Dec 15, 2020 · 3 comments · Fixed by #378
Assignees

Comments

@bethesque
Copy link
Member

Since we have de-duplicated the pact contents when verifying, we no longer get a webhook triggered for the verification results of each consumer version tag, meaning that only the most recent commit will get the updated verification status.

Pass the selected consumer version numbers and tags in the metadata, and when the webhook fires, trigger it once for each consumer version.

@bheemreddy181-zz
Copy link

Does this mean this is an issue when have two commits with same pact contents ?

@bethesque
Copy link
Member Author

Yes.

@bheemreddy181-zz
Copy link

I don’t think that is true the issue you linked to this has only one commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants