-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty response #383
Closed
Closed
Allow empty response #383
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
5cd0104
feat: allow disabling coloured output in Verifier
stan-is-hate e83db81
deps: go 1.17 deprecations
YOU54F fde24bd
chore: drop return value in test
YOU54F 553b0b6
chore: golangci-lint 1.55
YOU54F 2e5254e
docs: correct link to consumer version selector combinations
stan-is-hate f4af4b6
chore: downgrade avro plugin
YOU54F 94320b4
chore: update pact-protobuf-plugin 0.3.8
YOU54F 5aa9c49
chore: rm pact files
YOU54F db87b6f
chore: dg avro 0.0.3
YOU54F dea4094
build(deps): bump actions/setup-go from 4 to 5
dependabot[bot] 47ce584
build(deps): bump github.com/spf13/cobra from 1.7.0 to 1.8.0
dependabot[bot] bc70280
build(deps): bump github.com/hashicorp/go-getter from 1.7.2 to 1.7.3
dependabot[bot] e7a6056
build(deps): bump golang.org/x/net from 0.12.0 to 0.17.0
dependabot[bot] 176a00b
build(deps): bump google.golang.org/grpc from 1.58.1 to 1.60.1
dependabot[bot] 73cf688
build(deps): bump actions/setup-java from 3 to 4
dependabot[bot] eb6782d
build(deps): bump github.com/spf13/afero from 1.9.5 to 1.11.0
dependabot[bot] a97be49
fix: Dockerfile to reduce vulnerabilities
snyk-bot 84dd92e
build(deps): bump golang.org/x/crypto from 0.11.0 to 0.17.0
dependabot[bot] 7c19237
fix: allow empty message responses
stan-is-hate 74c30a1
Merge remote-tracking branch 'origin/master' into allow-empty
stan-is-hate File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
/vendor/ | ||
# Compiled Object files, Static and Dynamic libs (Shared Objects) | ||
*.o | ||
*.a | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
//go:build consumer || provider | ||
|
||
package grpc | ||
|
||
import "os" | ||
|
||
var dir, _ = os.Getwd() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,6 @@ import ( | |
"log" | ||
|
||
"net" | ||
"os" | ||
"path/filepath" | ||
"testing" | ||
|
||
|
@@ -20,8 +19,6 @@ import ( | |
"google.golang.org/grpc" | ||
) | ||
|
||
var dir, _ = os.Getwd() | ||
|
||
func TestGrpcProvider(t *testing.T) { | ||
go startProvider() | ||
l.SetLogLevel("TRACE") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably we should bring this back, and adjust it so that all builds use the same log level. I can do this after bringing this in. |
||
|
@@ -31,7 +28,7 @@ func TestGrpcProvider(t *testing.T) { | |
err := verifier.VerifyProvider(t, provider.VerifyRequest{ | ||
ProviderBaseURL: "http://localhost:8222", | ||
Transports: []provider.Transport{ | ||
provider.Transport{ | ||
{ | ||
Protocol: "grpc", | ||
Port: 8222, | ||
}, | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for clarity, are we dependent on pact-foundation/pact-reference#384 for this to be enabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're dependent on this one instead: pact-foundation/pact-reference@29b326e
my fix is for rust tests, Ronald fixed it for FFI