Allow empty response #383

stan-is-hate · 2024-02-08T01:36:06Z

This PR allows empty message responses. One use case is grpc error responses, where you might want to ensure the server responded with no message but just the status.

TODOs:

make sure CI works (avro plugin didn't start correctly on my machine, but might be that it doesn't support arm macs)
~~do we want to allow empty responses only when metadata is not empty? and if so, how to do it?~~ I think this should be handled in the rust part, not here. Here all we do is decode and pass the message into the test func.
~~why aren't matching rules supported in the metadata (might need a separate PR)~~ Support metadata rules for sync message pact-reference#384
~~can this be tested via unit tests~~ done, added unit tests
squash commits once reviewed (don't want to squash because changes might be required, wouldn't want to squash again)

mefellows

Couple of minor changes. Thanks so much for this 🙏

mefellows · 2024-02-12T03:58:08Z

examples/grpc/grpc_consumer_test.go

+
+			require.Error(t, err)
+			// TODO: uncomment once fixed on the ffi side
+			// require.ErrorContains(t, err, "no feature was found at latitude:-1  longitude:-1")


Just for clarity, are we dependent on pact-foundation/pact-reference#384 for this to be enabled?

We're dependent on this one instead: pact-foundation/pact-reference@29b326e
my fix is for rust tests, Ronald fixed it for FFI

mefellows · 2024-02-12T03:59:16Z

examples/grpc/grpc_provider_test.go

 func TestGrpcProvider(t *testing.T) {
 	go startProvider()
-	l.SetLogLevel("TRACE")


Probably we should bring this back, and adjust it so that all builds use the same log level. I can do this after bringing this in.

mefellows · 2024-02-12T04:00:04Z

examples/provider_test.go

-			filepath.ToSlash(fmt.Sprintf("%s/PactGoV3Consumer-V3Provider.json", pactDir)),
-			filepath.ToSlash(fmt.Sprintf("%s/PactGoV2ConsumerMatch-V2ProviderMatch.json", pactDir)),
-		},
+		// BrokerURL:       os.Getenv("PACT_BROKER_BASE_URL"),


Did you mean to leave these uncommented?

Yeah, I think these changes crept in from various manual testing, I'll go through and clean them up tomorrow.

coveralls · 2024-02-13T01:43:28Z

coverage: 37.243% (+0.04%) from 37.2%
when pulling 74c30a1 on stan-is-hate:allow-empty
into f04022c on pact-foundation:master.

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/hashicorp/go-getter](https://github.com/hashicorp/go-getter) from 1.7.2 to 1.7.3. - [Release notes](https://github.com/hashicorp/go-getter/releases) - [Changelog](https://github.com/hashicorp/go-getter/blob/main/.goreleaser.yml) - [Commits](hashicorp/go-getter@v1.7.2...v1.7.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/go-getter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.1 to 1.60.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.1...v1.60.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.9.5 to 1.11.0. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.9.5...v1.11.0) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-DEBIAN12-GLIBC-5927132 - https://snyk.io/vuln/SNYK-DEBIAN12-GLIBC-5927132 - https://snyk.io/vuln/SNYK-DEBIAN12-GLIBC-5927132 - https://snyk.io/vuln/SNYK-DEBIAN12-GLIBC-5927132 - https://snyk.io/vuln/SNYK-DEBIAN12-NGHTTP2-5953379

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.11.0 to 0.17.0. - [Commits](golang/crypto@v0.11.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

stan-is-hate · 2024-02-13T02:03:26Z

I'll close this one if you don't mind - I messed up the rebases and it's more hassle than it's worth to untangle them. I've opened #386 using a patch instead, so that one has a single commit :)

stan-is-hate marked this pull request as ready for review February 10, 2024 01:01

stan-is-hate changed the title ~~DRAFT: Allow empty response~~ Allow empty response Feb 10, 2024

mefellows approved these changes Feb 12, 2024

View reviewed changes

stan-is-hate and others added 19 commits February 12, 2024 17:45

feat: allow disabling coloured output in Verifier

5cd0104

deps: go 1.17 deprecations

e83db81

chore: drop return value in test

fde24bd

chore: golangci-lint 1.55

553b0b6

docs: correct link to consumer version selector combinations

2e5254e

chore: downgrade avro plugin

f4af4b6

chore: update pact-protobuf-plugin 0.3.8

94320b4

chore: rm pact files

5aa9c49

chore: dg avro 0.0.3

db87b6f

fix: allow empty message responses

7c19237

stan-is-hate force-pushed the allow-empty branch from 5da39bc to 7c19237 Compare February 13, 2024 01:45

Merge remote-tracking branch 'origin/master' into allow-empty

74c30a1

stan-is-hate mentioned this pull request Feb 13, 2024

fix: allow empty responses #386

Merged

stan-is-hate closed this Feb 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow empty response #383

Allow empty response #383

stan-is-hate commented Feb 8, 2024 •

edited

Loading

mefellows left a comment

mefellows Feb 12, 2024

stan-is-hate Feb 12, 2024

mefellows Feb 12, 2024

mefellows Feb 12, 2024

stan-is-hate Feb 12, 2024

coveralls commented Feb 13, 2024 •

edited

Loading

stan-is-hate commented Feb 13, 2024

Allow empty response #383

Allow empty response #383

Conversation

stan-is-hate commented Feb 8, 2024 • edited Loading

mefellows left a comment

Choose a reason for hiding this comment

mefellows Feb 12, 2024

Choose a reason for hiding this comment

stan-is-hate Feb 12, 2024

Choose a reason for hiding this comment

mefellows Feb 12, 2024

Choose a reason for hiding this comment

mefellows Feb 12, 2024

Choose a reason for hiding this comment

stan-is-hate Feb 12, 2024

Choose a reason for hiding this comment

coveralls commented Feb 13, 2024 • edited Loading

stan-is-hate commented Feb 13, 2024

stan-is-hate commented Feb 8, 2024 •

edited

Loading

coveralls commented Feb 13, 2024 •

edited

Loading