-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/review #36
Feature/review #36
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ public with sharing class InvestmentStatisticsService { | |
|
||
Decimal previousTotal; | ||
while (weekNumber <= lastWeekNumber) { | ||
System.debug('test'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid debug statements since they impact on performance (pmd - AvoidDebugStatements - Severity: 3) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Calls to System.debug should specify a logging level. (pmd - DebugsShouldUseLoggingLevel - Severity: 3) |
||
InvestmentSnapshot__c thisWeek = this.snapshots.containsKey(weekNumber) | ||
? this.snapshots.get(weekNumber) | ||
: new InvestmentSnapshot__c( | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
public without sharing class TA_InvestmentUpdate_SetCurrency implements packocz.TriggerAction.BeforeInsert { | ||
@namespaceAccessible | ||
public void beforeInsert(List<InvestmentUpdate__c> newList) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Source Type: TA_InvestmentUpdate_SetCurrency, Source Method: beforeInsert, Sink File: invest-app/main/default/classes/TA_InvestmentUpdate_SetCurrency.cls: 11 ### FLS validation is missing for [READ] operation on [Investment__c] with field(s) [CurrencyIsoCode]. (sfge - ApexFlsViolationRule - Severity: 1) |
||
System.debug('test'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid debug statements since they impact on performance (pmd - AvoidDebugStatements - Severity: 3) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Calls to System.debug should specify a logging level. (pmd - DebugsShouldUseLoggingLevel - Severity: 3) |
||
Set<Id> investmentIds = new Set<Id>(); | ||
for (InvestmentUpdate__c iu : newList) { | ||
investmentIds.add(iu.Investment__c); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
trigger InvestmentUpdate on InvestmentUpdate__c(before insert, after insert, after update, after delete) { | ||
System.debug('test'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Avoid debug statements since they impact on performance (pmd - AvoidDebugStatements - Severity: 3) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Calls to System.debug should specify a logging level. (pmd - DebugsShouldUseLoggingLevel - Severity: 3) |
||
new packocz.MetadataTriggerHandler().run(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid empty block statements. (pmd - EmptyStatementBlock - Severity: 3)