Feature/review #36
Feature/review #36
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -14,6 +14,7 @@ public with sharing class InvestmentStatisticsJob implements Database.Batchable< | |||
| InvestmentStatisticsService stats = new InvestmentStatisticsService(investment.Id, this.startDate); | |||
| stats.process(); | |||
| stats.save(); | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Avoid debug statements since they impact on performance (pmd - AvoidDebugStatements - Severity: 3)
| @@ -14,6 +14,7 @@ public with sharing class InvestmentStatisticsJob implements Database.Batchable< | |||
| InvestmentStatisticsService stats = new InvestmentStatisticsService(investment.Id, this.startDate); | |||
| stats.process(); | |||
| stats.save(); | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Calls to System.debug should specify a logging level. (pmd - DebugsShouldUseLoggingLevel - Severity: 3)
| @@ -14,6 +14,7 @@ public with sharing class InvestmentStatisticsJob implements Database.Batchable< | |||
| InvestmentStatisticsService stats = new InvestmentStatisticsService(investment.Id, this.startDate); | |||
| stats.process(); | |||
| stats.save(); | |||
| System.debug('test'); | |||
| } | |||
| } | |||
| public void finish(Database.BatchableContext bc) { | |||
There was a problem hiding this comment.
Avoid empty block statements. (pmd - EmptyStatementBlock - Severity: 3)
| @@ -31,6 +31,7 @@ public with sharing class InvestmentStatisticsService { | |||
|
|
|||
| Decimal previousTotal; | |||
| while (weekNumber <= lastWeekNumber) { | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Avoid debug statements since they impact on performance (pmd - AvoidDebugStatements - Severity: 3)
| @@ -31,6 +31,7 @@ public with sharing class InvestmentStatisticsService { | |||
|
|
|||
| Decimal previousTotal; | |||
| while (weekNumber <= lastWeekNumber) { | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Calls to System.debug should specify a logging level. (pmd - DebugsShouldUseLoggingLevel - Severity: 3)
| @@ -2,6 +2,7 @@ | |||
| public without sharing class TA_InvestmentUpdate_SetCurrency implements packocz.TriggerAction.BeforeInsert { | |||
| @namespaceAccessible | |||
| public void beforeInsert(List<InvestmentUpdate__c> newList) { | |||
There was a problem hiding this comment.
Source Type: TA_InvestmentUpdate_SetCurrency, Source Method: beforeInsert, Sink File: invest-app/main/default/classes/TA_InvestmentUpdate_SetCurrency.cls: 11 ### FLS validation is missing for [READ] operation on [Investment__c] with field(s) [CurrencyIsoCode]. (sfge - ApexFlsViolationRule - Severity: 1)
| @@ -2,6 +2,7 @@ | |||
| public without sharing class TA_InvestmentUpdate_SetCurrency implements packocz.TriggerAction.BeforeInsert { | |||
| @namespaceAccessible | |||
| public void beforeInsert(List<InvestmentUpdate__c> newList) { | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Avoid debug statements since they impact on performance (pmd - AvoidDebugStatements - Severity: 3)
| @@ -2,6 +2,7 @@ | |||
| public without sharing class TA_InvestmentUpdate_SetCurrency implements packocz.TriggerAction.BeforeInsert { | |||
| @namespaceAccessible | |||
| public void beforeInsert(List<InvestmentUpdate__c> newList) { | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Calls to System.debug should specify a logging level. (pmd - DebugsShouldUseLoggingLevel - Severity: 3)
| @@ -1,3 +1,4 @@ | |||
| trigger InvestmentUpdate on InvestmentUpdate__c(before insert, after insert, after update, after delete) { | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Avoid debug statements since they impact on performance (pmd - AvoidDebugStatements - Severity: 3)
| @@ -1,3 +1,4 @@ | |||
| trigger InvestmentUpdate on InvestmentUpdate__c(before insert, after insert, after update, after delete) { | |||
| System.debug('test'); | |||
There was a problem hiding this comment.
Calls to System.debug should specify a logging level. (pmd - DebugsShouldUseLoggingLevel - Severity: 3)
packocz
force-pushed
the
feature/review
branch
from
8bafc5c to
48a2f33
Compare
packocz
force-pushed
the
feature/review
branch
from
48a2f33 to
deece17
Compare
No description provided.