Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aarch64 Testing Farm composes does not need to be suffixed #2028

Closed
3 tasks
lachmanfrantisek opened this issue Apr 28, 2023 · 1 comment · Fixed by #2224
Closed
3 tasks

aarch64 Testing Farm composes does not need to be suffixed #2028

lachmanfrantisek opened this issue Apr 28, 2023 · 1 comment · Fixed by #2224
Assignees
@lbarcziova
Labels
area/testing-farm Related to Testing Farm integration. complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/refactor Technical debt - the code needs love.

Comments

@lachmanfrantisek
Copy link
Member

lachmanfrantisek commented Apr 28, 2023 •
edited
Loading

The aarch64 composes used to be named differently because of what we have to behave specifically for those:

TBD

This is no longer true and we can use the same compose names for aarch64 as well. Both names are possible for now but will be deprecated.

TODO:

  • Remove the specific handling for aarch64.
  • Enhance tests to cover that change.
  • Let @thrix know we're done

Here is an example provided by @thrix :

❯ testing-farm-public request --git-url https://gitlab.com/testing-farm/tests --plan /testing-farm/sanity --compose CentOS-Stream-9 --arch aarch64
📦 repository https://gitlab.com/testing-farm/tests ref main test-type fmf
💻 CentOS-Stream-9 on aarch64 
🔎 api https://api.dev.testing-farm.io/v0.1/requests/a3dc8251-7a2d-40b6-984d-289c9a6ef79f
💡 waiting for request to finish, use ctrl+c to skip
👷 request is queued
🚀 request is running
🚢 artifacts https://artifacts.dev.testing-farm.io/a3dc8251-7a2d-40b6-984d-289c9a6ef79f
✅ tests passed
@lachmanfrantisek lachmanfrantisek added kind/refactor Technical debt - the code needs love. area/testing-farm Related to Testing Farm integration. complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Apr 28, 2023
@lachmanfrantisek lachmanfrantisek moved this from new to backlog in Packit Kanban Board May 4, 2023
@lbarcziova lbarcziova mentioned this issue Sep 8, 2023
Closed
@thrix
Copy link
Contributor

thrix commented Oct 11, 2023

This is now a bug, see https://redhat-internal.slack.com/archives/C03BRN71JAF/p1697035020889869

@lbarcziova lbarcziova self-assigned this Oct 11, 2023
@lbarcziova lbarcziova moved this from backlog to in-progress in Packit Kanban Board Oct 11, 2023
This was referenced Oct 11, 2023
Closed
Draft
lbarcziova added a commit to lbarcziova/packit-service that referenced this issue Oct 11, 2023
@lbarcziova
Do not suffix aarch64 composes for TF
ddbc09b 
This is no longer required from TF.
Fixes packit#2028
@lbarcziova lbarcziova mentioned this issue Oct 11, 2023
Merged
softwarefactory-project-zuul bot added a commit that referenced this issue Oct 11, 2023
@softwarefactory-project-zuul
Do not suffix aarch64 composes for TF (#2224)
4c42981 
Do not suffix aarch64 composes for TF

This is no longer required from TF.
Fixes #2028

RELEASE NOTES BEGIN
N/A
RELEASE NOTES END

Reviewed-by: František Lachman <[email protected]>
@lbarcziova lbarcziova moved this from in-progress to done in Packit Kanban Board Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbarcziova lbarcziova

Labels
area/testing-farm Related to Testing Farm integration. complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/refactor Technical debt - the code needs love.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not suffix aarch64 composes for TF lbarcziova/packit-service
3 participants
@thrix @lachmanfrantisek @lbarcziova