Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit matching wrong composes #2223

Closed
2 tasks done
thrix opened this issue Oct 11, 2023 · 2 comments
Closed
2 tasks done

Packit matching wrong composes #2223

thrix opened this issue Oct 11, 2023 · 2 comments
Labels
kind/bug Something isn't working.

Comments

@thrix
Copy link
Contributor

thrix commented Oct 11, 2023

What happened? What is the problem?

See:

https://github.com/containers/skopeo/pull/1960/checks?check_run_id=17604399795

And the setup:

https://github.com/containers/skopeo/blob/2e9afc94bcc89f72d3df98bf61ec338d50700993/.packit.yaml

The RHEL-8.10.0-Nightly-x86_64 should have not been matched with re.fullmatch, but it was?

if self.is_compose_matching(target, compiled_composes):

What did you expect to happen?

RHEL-8.10.0-Nightly-x86_64 not matches

Example URL(s)

See What happened section.

Steps to reproduce

See what happened section.

What is the impacted category (job)?

Testing Farm tests

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@thrix
Copy link
Contributor Author

thrix commented Oct 11, 2023

As a workaround we had to add $ everywhere in our composes endpoint listing:
https://api.dev.testing-farm.io/v0.1/composes/redhat

@thrix
Copy link
Contributor Author

thrix commented Oct 11, 2023

Closing as a dupe of #2028

@thrix thrix closed this as completed Oct 11, 2023
@github-project-automation github-project-automation bot moved this from new to done in Packit Kanban Board Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working.
Projects
Archived in project
Development

No branches or pull requests

1 participant