Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display selected watershed on map #425

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Display selected watershed on map #425

merged 4 commits into from
Nov 2, 2022

Conversation

corviday
Copy link
Contributor

@corviday corviday commented Oct 28, 2022 •
edited
Loading

This PR does the following:

  • when a user selects the outlet of a watershed on the map, make a call to the watershed API and display the outline of the watershed on the map
  • switch from the Upper Fraser dataset to the entire Fraser dataset (different data ensembles in the base URL)

Demo here: https://services.pacificclimate.org/dev/pcex/app/#/data/flood/fraser

rod-glover
rod-glover approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@rod-glover rod-glover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would suggest black for the outline of upstream polgyon; it's hard to see the blue against many of the raster's blue-ish colours.

@corviday corviday merged commit 2c09b1f into master Nov 2, 2022
@corviday corviday deleted the flood-update branch November 2, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rod-glover rod-glover rod-glover approved these changes

@eyvorchuk eyvorchuk Awaiting requested review from eyvorchuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corviday @rod-glover