Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "external IP hack" (#236) #311

Merged
merged 3 commits into from
May 2, 2023
Merged

Remove the "external IP hack" (#236) #311

merged 3 commits into from
May 2, 2023

Conversation

rzezeski
Copy link
Contributor

No description provided.

@bnaecker
Copy link
Contributor

I just wanted to check about timing here. There's a lot of integration with Dendrite needed before we can really provision instances that don't use the hack. Is the plan to keep this up and in-waiting until we do that? That's fine by me, just checking.

@rzezeski
Copy link
Contributor Author

@bnaecker I just wanted to make sure I had a PR floated before I take leave. Though, to be fair, it could always be merged and you just have to just stay on the previous commit until you are ready to transition Omicron to the new world order (speaking of which, I believe we are already several PRs behind in Omicron that would update opte).

Anyways, I'll leave it to you when this should land.

@bnaecker
Copy link
Contributor

Oh duh, I forgot we pin a commit in Omicron. Thanks!

@luqmana

This comment was marked as outdated.

@luqmana luqmana force-pushed the rpz-rm-ext-ip-hack branch from 229db4f to deb795b Compare May 2, 2023 00:55
@luqmana
Copy link
Contributor

luqmana commented May 2, 2023

With SoftNPU having landed a couple of weeks ago, omicron has since transitioned from requiring the external IP hack. It's finally time to get rid of it altogether!

@luqmana luqmana merged commit 05ea62e into master May 2, 2023
@luqmana luqmana deleted the rpz-rm-ext-ip-hack branch May 2, 2023 01:27
@luqmana luqmana mentioned this pull request May 2, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants