Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the "external IP hack" #236

Closed
7 tasks
Tracked by #235
rzezeski opened this issue Aug 19, 2022 · 2 comments · Fixed by oxidecomputer/omicron#2089
Closed
7 tasks
Tracked by #235

Remove the "external IP hack" #236

rzezeski opened this issue Aug 19, 2022 · 2 comments · Fixed by oxidecomputer/omicron#2089
Assignees
@rzezeski @bnaecker
Labels
mvp
Milestone
MVP

Comments

@rzezeski
Copy link
Contributor

Once we have the ability to simulate Boundary Services we'll want to remove all code related to the "external IP hack". Below is a list of things to check for code to remove. It's not simply a matter of reverting the commits listed below, as some legit fixes are also intertwined. However, deleting anything commented with XXX-EXT-IP or gated behind xde_ext_ip_hack should allow the compiler to make sure you clean everything up.

  • Grep for all instances of XXX-EXT-IP in the code.
  • Commit 52176b99cc578f5b7b90f9bae8935013f961086c
  • Commit 23884d35aa7908e23accaa77f125a370ddf5c606
  • Commit 3ea62a9b77f58dbbbf7dd772362b0d008c548e87
  • Commit 1f8c0a1ed65b296da3876017ea0040bc1b4c6601
  • Commit 92a3ae21ffd9405a6897b5136410e2b11ee74005
  • Commit 14410f9420184702fa4b0ee134a0aa37216398eb
@rzezeski rzezeski added the mvp label Aug 19, 2022
@rzezeski rzezeski mentioned this issue Aug 19, 2022
Open
13 tasks
@bnaecker bnaecker mentioned this issue Oct 17, 2022
Open
9 tasks
rzezeski added a commit that referenced this issue Dec 23, 2022
@rzezeski
Remove the "external IP hack" (#236)
229db4f
@internet-diglett internet-diglett mentioned this issue Jan 10, 2023
Merged
11 tasks
@luqmana
Copy link
Contributor

luqmana commented Mar 22, 2023

Gonna keep this open until we cleanup things in opte. But 🎉 now that we have softnpu!

@luqmana luqmana reopened this Mar 22, 2023
@bnaecker bnaecker added this to the MVP milestone Apr 11, 2023
luqmana pushed a commit that referenced this issue May 2, 2023
@rzezeski @luqmana
Remove the "external IP hack" (#236)
59ce448
luqmana pushed a commit that referenced this issue May 2, 2023
@rzezeski
Remove the "external IP hack" (#236) (#311)
05ea62e 
* Remove the "external IP hack"
* Remove xde_ext_ip_hack from xde.conf
* Bump API version for EXT-IP-HACK free world.
---------
Co-authored-by: Luqman Aden <[email protected]>
@luqmana
Copy link
Contributor

luqmana commented May 2, 2023

Remaining OPTE bits removed in #311

@luqmana luqmana closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rzezeski rzezeski

@bnaecker bnaecker

Labels
mvp
Projects
None yet
Milestone
MVP
Development

Successfully merging a pull request may close this issue.

Integrate SoftNPU as virtual hardware oxidecomputer/omicron
3 participants
@rzezeski @luqmana @bnaecker