Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update resource limits as per #3212 #3819

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Update resource limits as per #3212 #3819

merged 2 commits into from
Aug 7, 2023

Conversation

zephraph
Copy link
Contributor

@zephraph zephraph commented Aug 4, 2023

Fixes #3212

vCPUs: 32 -> 64
memory: 64 GiB -> 256 GiB
disk size: 1 TiB -> 1023 GiB

@zephraph zephraph marked this pull request as ready for review August 4, 2023 17:23
@zephraph zephraph requested a review from david-crespo August 4, 2023 19:01
@david-crespo
Copy link
Contributor

The fact that no tests fail with this change is a little concerning!

@zephraph
Copy link
Contributor Author

zephraph commented Aug 4, 2023

The tests uses the constants to pivot off of. I don't see the value of hardcoding the limits in the tests.

So you have situations like this:

    let disk_size =
        ByteCount::try_from(MAX_DISK_SIZE_BYTES + (1 << 30)).unwrap();

where we use the limits to create a value over the limit to ensure that it fails.

Copy link
Contributor

@david-crespo david-crespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense. Cool!

@zephraph zephraph merged commit 1b23673 into main Aug 7, 2023
@zephraph zephraph deleted the update-limits branch August 7, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to create a VM with more than 32 vcpus brings nexus down
2 participants