Skip to content

Commit

Permalink
Update resource limits as per #3212 (#3819)
Browse files Browse the repository at this point in the history
  • Loading branch information
zephraph authored Aug 7, 2023
1 parent 90c9860 commit 1b23673
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions nexus/src/app/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,13 @@ pub(crate) const MAX_NICS_PER_INSTANCE: usize = 8;
// TODO-completeness: Support multiple external IPs
pub(crate) const MAX_EXTERNAL_IPS_PER_INSTANCE: usize = 1;

pub const MAX_VCPU_PER_INSTANCE: u16 = 32;
pub const MAX_VCPU_PER_INSTANCE: u16 = 64;

pub const MIN_MEMORY_BYTES_PER_INSTANCE: u32 = 1 << 30; // 1 GiB
pub const MAX_MEMORY_BYTES_PER_INSTANCE: u64 = 64 * (1 << 30); // 64 GiB
pub const MAX_MEMORY_BYTES_PER_INSTANCE: u64 = 256 * (1 << 30); // 256 GiB

pub const MIN_DISK_SIZE_BYTES: u32 = 1 << 30; // 1 GiB
pub const MAX_DISK_SIZE_BYTES: u64 = 1 << 40; // 1 TiB
pub const MAX_DISK_SIZE_BYTES: u64 = 1023 * (1 << 30); // 1023 GiB

/// Manages an Oxide fleet -- the heart of the control plane
pub struct Nexus {
Expand Down
4 changes: 2 additions & 2 deletions nexus/tests/integration_tests/disks.rs
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ async fn test_disk_reject_total_size_not_divisible_by_block_size(

// Tests that a disk is rejected if the total size is less than MIN_DISK_SIZE
#[nexus_test]
async fn test_disk_reject_total_size_less_than_one_gibibyte(
async fn test_disk_reject_total_size_less_than_min_disk_size_bytes(
cptestctx: &ControlPlaneTestContext,
) {
let client = &cptestctx.external_client;
Expand Down Expand Up @@ -891,7 +891,7 @@ async fn test_disk_reject_total_size_less_than_one_gibibyte(
}

#[nexus_test]
async fn test_disk_reject_total_size_greater_than_one_tebibyte(
async fn test_disk_reject_total_size_greater_than_max_disk_size_bytes(
cptestctx: &ControlPlaneTestContext,
) {
let client = &cptestctx.external_client;
Expand Down

0 comments on commit 1b23673

Please sign in to comment.