Revert deploy log snapshot, don't collect propolis logs as CI artifacts. #3263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to have caused more frequently occuring problems than were there before - so revert it.
This can cause CI collection to fail when the file being collected is deleted.
davepacheco
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3241 I was running into an issue with the deploy job, where artifact collection would fail because propolis logs were being deleted during collection. In that PR i attempted to create a snapshot before collection, only to have the snapshot fail for the same reason. This commit does two things.
The output rule added here was originally in the buildomat job. It was removed in #1902 to get better visibility of propolis logs on CI output. However, to do that without risk of failing collection we need to stash the logs somewhere safe before deleting instances as a part of the e2e tests.