-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump dendrite/maghemite #3241
Merged
Merged
bump dendrite/maghemite #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jmpesp
approved these changes
May 26, 2023
rcgoodfellow
force-pushed
the
omicron-maghemite-bump
branch
from
May 27, 2023 07:51
a2b7530
to
81c6c8c
Compare
rcgoodfellow
force-pushed
the
omicron-maghemite-bump
branch
from
May 27, 2023 17:45
822b102
to
57dfd91
Compare
FWIW, the % prefix allows the files to change while they're being uploaded. What error did you see from buildomat? |
You can see the error in this run. It looks like the propolis log file disappeared out from under the artifact collection. |
Pulling in @internet-diglett to look at the rack initialize changes. |
@rcgoodfellow looks good to me! |
internet-diglett
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in
Dendrite
Maghemite