Add minitable to Floating IP side modal #2630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Yeah, I had the same reaction about it being a lot of noise. Collapsing it is an interesting idea. Ben will have to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #994, Justin noted the absence of some resource details at the top of side modals. (That is, non-editable details that might pertain to the editable fields of the form.) This PR just picks up the Floating IP side modal and adds the relevant info.
Well, hm. After adding all of the data (id, dates), that's an awful lot of forehead on the form. I wonder if we should put it in a pre-collapsed, expandable element
Happy to pick up more, but figured this was a tightly-scoped one.